Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sats Connect kit #87

Merged
merged 29 commits into from
Apr 6, 2024
Merged

Sats Connect kit #87

merged 29 commits into from
Apr 6, 2024

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Mar 26, 2024 •
edited
Loading

  • move all the existing code to @sats-connect/core
  • register wallet selector from @sats-connect/ui
  • create a wallet instance that handles wallet adapters
  • add an app template

@m-aboelenein m-aboelenein self-assigned this Mar 26, 2024
aryzing
aryzing reviewed Apr 5, 2024
View reviewed changes
README.md Outdated

### import

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```ts

aryzing
aryzing reviewed Apr 5, 2024
View reviewed changes
README.md Outdated

### Connect Wallet

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```ts

aryzing
aryzing reviewed Apr 5, 2024
View reviewed changes
README.md Outdated
Comment on lines 37 to 44
const response = await Wallet.request('getAccounts', {
purposes: [
AddressPurpose.Payment,
AddressPurpose.Ordinals,
AddressPurpose.Stacks
],
message: 'Cool app wants to know your addresses!'
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier can format this if ```ts is set above, does it work?

aryzing
aryzing reviewed Apr 5, 2024
View reviewed changes
README.md Outdated
```
### Request a wallet action

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```ts

aryzing
aryzing reviewed Apr 5, 2024
View reviewed changes
README.md Outdated

### Disconnect Wallet

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```ts

@m-aboelenein m-aboelenein merged commit cd71d22 into develop Apr 6, 2024
3 checks passed
@m-aboelenein m-aboelenein deleted the connect-kit/v0 branch April 6, 2024 12:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

Test this PR with npm i --save-exact [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryzing aryzing aryzing approved these changes

Assignees

@m-aboelenein m-aboelenein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-aboelenein @aryzing